Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update soflev1.json - encoder support #1841

Merged
merged 1 commit into from
May 13, 2023
Merged

Update soflev1.json - encoder support #1841

merged 1 commit into from
May 13, 2023

Conversation

ireun
Copy link
Contributor

@ireun ireun commented Apr 29, 2023 •
edited
Loading

Description

  • Add encoder definition to layout
  • removed decal

This PR will make it possible to update the VIA keymap in the QMK repo to enable modifying encoder mapping using VIA.

QMK Pull Request

qmk/qmk_firmware#10446

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

image

@ireun
Update soflev1.json
d4cf19b 
* Add encoder definition to layout
* removed decal
@ireun ireun changed the title Update soflev1.json Update soflev1.json - encoder support Apr 29, 2023
@ireun ireun mentioned this pull request Apr 29, 2023
Merged
14 tasks
@Xelus22
Copy link
Collaborator

Xelus22 commented May 2, 2023

Note: waiting on qmk/qmk_firmware#20630

@ireun
Copy link
Contributor Author

ireun commented May 4, 2023

@Xelus22 QMK part of this PR just got merged, I think We can move on. :)

@Xelus22 Xelus22 merged commit 0e7ffe0 into the-via:master May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ireun @Xelus22